Move percy keys from encrypted .travis.yml entries to travis config #9314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwinmombay: Ping. |
|
@kmh287 for review. |
kmh287
reviewed
May 17, 2017
| @@ -58,7 +58,9 @@ function extractPercyKeys() { | |||
| 'Error: PERCY_TOKEN doesn\'t look like a valid Percy API key')); | |||
| process.exit(1); | |||
| } | |||
| util.log('Percy token: ', util.colors.magenta('<redacted>')); | |||
| // Note: The secret percy token only gets printed during local use. Travis | |||
There was a problem hiding this comment.
Who will be able to see the token?
There was a problem hiding this comment.
Only engineers who want to do a local visual diff run, who already have access to the tokens. Those who access the public travis logs will not see the token in the logs.
| @@ -39,8 +39,6 @@ branches: | |||
| env: | |||
| global: | |||
| - NPM_CONFIG_PROGRESS="false" | |||
| - secure: nvLqQdU2CGwvsQ3E1M/6HgBJAfmSzd90bDYQ1vkAkwGj+VOVQauqj7RDJACJS2XysJjzIvzNUOtKFvTSzThye167sKAZnQMmj9U8ATdlJfv5xq88QkkoCuJIOPtVnOWS8gBrDAy9d+Xwi22ZcE5kAAov1gNDmnX6YcPwW8y09vD+Jb1WkxofwTR5U3dP7pxVNRwgXY12g2lmbj+TZy5RHvjs1/ESSVtt/5Wq+Ubv9O6KAVPrh/VdVTYyvgynvwzz5jG3qe7981W8rUNIt+ihzdxJMSaoQkiBs5UM3qi8ibqKI2KHdDmGQg+vc/c5mjCCd9FAz7lF+fJJQ3YThTLmIN3u7Hil+o92OaAt2knwtZ3HRv/jbVQfnU0L9hqHw/kBYE37O4x4/ToJyR3EgbvFXqgiVph0eDUnsmi8PZc5FUiwb8r85thQmfUB+urkOXbnOyHQ9B74T+UjAvlaqLdQ53/9UTzgvLNm2z6RU65G9QYJVMSzj82K2rZ9AyVwjZMp/iuQDoUcUsuMhKDh2genHnxRtQa/TbLQM05oYHRqFa9oT3Q7C7QSSL8mmi/QMfGlTfxhM49CZsbcU2qbMCMCL7ZGWaSiXiEy7XICOzJnOiKFowDK5ihAZaQpRNquMwUSIMnnqrFgfWDbQSUmkOAwSm+2u2+SsXhT+WQfraRfSSI= | |||
There was a problem hiding this comment.
These were moved elsewhere right? Is it okay that these were publicly visible on github?
There was a problem hiding this comment.
Yes. This is travis' mechanism to safely do that.
There was a problem hiding this comment.
These are now part of the travis config, and are in a mode where they are not printed within logs. This is exactly how we store our sauce tokens.
cramforce
approved these changes
May 17, 2017
kmh287
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is up with how Travis consumes encrypted keys from .travis.yml. The tests are now using the keys as set in the travis settings page. See https://travis-ci.org/ampproject/amphtml/builds/231611667 for an example of a successful percy run for a push to master.
Issues #8, #8340, #9069